Remove deadcode checker #472
Merged
+1
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bschimke95
force-pushed
the
bschimke95/remove-deadcode-checker
branch
from
bd7f211 to
7cbed27
Compare
The deadcode checker doesn't work well with our features setup as it detects non-main feature modules (that are used e.g. in moonray) as unused and blocks the CI. That checker hasn't really contributed anything useful anyway, so let's just remove it.
bschimke95
force-pushed
the
bschimke95/remove-deadcode-checker
branch
from
7cbed27 to
d0e1400
Compare
|
Not necessary, we can use Go tags instead: #473 |
|
Looks like we do not get around the deadcode checker removal - the tags are only applied on implementation level but e.g. the calico feature is still detected as unused. |
eaudetcobello
pushed a commit
that referenced
this pull request
Jun 6, 2024
The deadcode checker doesn't work well with our features setup as it detects non-main feature modules (that are used e.g. in moonray) as unused and blocks the CI. That checker hasn't really contributed anything useful anyway, so let's just remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The deadcode checker doesn't work well with our features setup as it detects non-main feature modules (that are used e.g. in moonray) as unused and blocks the CI.
That checker hasn't really contributed anything useful anyway, so let's just remove it.